Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTP Next] Prototype #27228

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[NTP Next] Prototype #27228

wants to merge 1 commit into from

Conversation

zenparsing
Copy link
Collaborator

This branch contains the latest draft work on the NTP next feature.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jan 14, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch from 3a622e4 to d001c5c Compare January 14, 2025 16:44
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing changed the title [NTP Next] Feature preview [NTP Next] Prototype Jan 21, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch from be9011a to 3fb6d9e Compare January 21, 2025 15:42
Copy link
Contributor

Chromium major version is behind target branch (132.0.6834.83 vs 133.0.6943.27). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Jan 27, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch from 3fb6d9e to 1c5a6f5 Compare January 30, 2025 23:02
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Jan 30, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch 6 times, most recently from 084692d to 9b3f146 Compare February 5, 2025 14:53
@zenparsing zenparsing added the CI/run-macos-x64 Run CI builds for macOS x64 label Feb 5, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch 2 times, most recently from f4c6949 to 296891a Compare February 13, 2025 19:17
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch 3 times, most recently from 151916d to 3e7ecae Compare February 14, 2025 12:51
@zenparsing zenparsing removed the CI/run-macos-x64 Run CI builds for macOS x64 label Feb 14, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch from 3e7ecae to f30731b Compare February 14, 2025 15:59
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch from f30731b to a4f1625 Compare February 19, 2025 17:41
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 19, 2025
@zenparsing zenparsing force-pushed the ksmith-ntp-next-draft branch from e1dec73 to 881dbfa Compare February 28, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants